Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use enum to return precise FIFO state #1009

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

use enum to return precise FIFO state #1009

wants to merge 1 commit into from

Conversation

2bndy5
Copy link
Member

@2bndy5 2bndy5 commented Nov 19, 2024

I got this idea from developing rf24-rs project.

This has the advantage of accurately describing a FIFO's state (including data corruption over SPI) when using RF24::isFifo().

I also deprecated the overloaded RF24::isFifo(bool about_tx, bool check_empty) because the data returned could be considered inaccurate.

@github-actions GitHub Actions
Copy link
Contributor

Memory usage change @ fd90bc4

Board flash % RAM for global variables %
arduino:avr:nano 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:samd:mkrzero 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
Click for full report table
Board examples/GettingStarted
flash		 % examples/GettingStarted
RAM for global variables		 % examples/AcknowledgementPayloads
flash		 % examples/AcknowledgementPayloads
RAM for global variables		 % examples/ManualAcknowledgements
flash		 % examples/ManualAcknowledgements
RAM for global variables		 % examples/StreamingData
flash		 % examples/StreamingData
RAM for global variables		 % examples/MulticeiverDemo
flash		 % examples/MulticeiverDemo
RAM for global variables		 % examples/InterruptConfigure
flash		 % examples/InterruptConfigure
RAM for global variables		 % examples/scanner
flash		 % examples/scanner
RAM for global variables		 % examples/encodeRadioDetails
flash		 % examples/encodeRadioDetails
RAM for global variables		 %
arduino:avr:nano 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0
arduino:samd:mkrzero 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0
Click for full report CSV 
Board,examples/GettingStarted<br>flash,%,examples/GettingStarted<br>RAM for global variables,%,examples/AcknowledgementPayloads<br>flash,%,examples/AcknowledgementPayloads<br>RAM for global variables,%,examples/ManualAcknowledgements<br>flash,%,examples/ManualAcknowledgements<br>RAM for global variables,%,examples/StreamingData<br>flash,%,examples/StreamingData<br>RAM for global variables,%,examples/MulticeiverDemo<br>flash,%,examples/MulticeiverDemo<br>RAM for global variables,%,examples/InterruptConfigure<br>flash,%,examples/InterruptConfigure<br>RAM for global variables,%,examples/scanner<br>flash,%,examples/scanner<br>RAM for global variables,%,examples/encodeRadioDetails<br>flash,%,examples/encodeRadioDetails<br>RAM for global variables,%
arduino:avr:nano,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:samd:mkrzero,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@2bndy5